Rename some properties for consistency #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
reviewed
Dec 13, 2018
| @@ -14,7 +14,7 @@ public class Account : StripeEntity, IHasId, IHasMetadata, IHasObject, IPaymentS | |||
| public string Object { get; set; } | |||
|
|
|||
| #region Expandable BusinessLogo | |||
| public string BusinessLogoFileId { get; set; } | |||
| public string BusinessLogoId { get; set; } | |||
There was a problem hiding this comment.
Hmmmm Are we sure we want to get rid of the File part? This was a good way to infer something is the file id. The new name does not match the API name either.
There was a problem hiding this comment.
It's internally inconsistent with how other expandable fields are named and how attributes are named in general.
That said, I can add XML comments to indicate that this is a file ID.
|
@ob-stripe I'm fine with it so if you prefer that naming, feel free to merge! |
ob-stripe
force-pushed
the
ob-rename-props
branch
from
b21f4ec to
02e3685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
Renames some properties for consistency with the API:
Account.BusinessLogoFileIdAccount.BusinessLogoIdLegalEntityVerification.DocumentIdBackLegalEntityVerification.DocumentBackIdEvidence.CancellationPolicyFileIdEvidence.CancellationPolicyIdEvidence.CancellationPolicyFileEvidence.CancellationPolicyEvidence.CustomerCommunicationFileIdEvidence.CustomerCommunicationIdEvidence.CustomerCommunicationFileEvidence.CustomerCommunicationEvidence.CustomerSignatureFileIdEvidence.CustomerSignatureIdEvidence.CustomerSignatureFileEvidence.CustomerSignatureEvidence.CustomerSignatureFileIdEvidence.CustomerSignatureIdEvidence.CustomerSignatureFileEvidence.CustomerSignatureEvidence.DuplicateChargeDocumentationFileIdEvidence.DuplicateChargeDocumentationIdEvidence.DuplicateChargeDocumentationFileEvidence.DuplicateChargeDocumentationEvidence.ReceiptFileIdEvidence.ReceiptIdEvidence.ReceiptFileEvidence.ReceiptEvidence.RefundPolicyFileIdEvidence.RefundPolicyIdEvidence.RefundPolicyFileEvidence.RefundPolicyEvidence.ServiceDocumentationFileIdEvidence.ServiceDocumentationIdEvidence.ServiceDocumentationFileEvidence.ServiceDocumentationEvidence.ShippingDocumentationFileIdEvidence.ShippingDocumentationIdEvidence.ShippingDocumentationFileEvidence.ShippingDocumentation